-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use g++-4.8 (support C++11) and start testing against Node.js version 4.0 on Travis CI #105
Conversation
The first of the above problems seems to be a problem of |
See my comment here: the problem is with the default C++ compiler, it's too old to understand C++11. |
install a C++11-capable compiler
Thanks, the first problem is gone. Travis CI job logs for iojs and Node.js v4.0.0 now seem to indicate that |
It also looks like Node.js 4.0 can no longer natively decode CESU-8. |
Yes, that was removed in nodejs/node@70d1f32 ("deps: update v8 to 4.4.63.9"):
Long story short: V8 string functions no longer accept CESU-8 as input. Node would have to implement its own UTF-8-to-UTF-16 encoder. |
Created some Buffers: Their lengths are fine, but their contents seem quite random. I suspect that the new version of Node's |
use g++-4.8 (support C++11) and start testing against Node.js version 4.0 on Travis CI
Thanks @Mithgol! I fixed the CESU-8 and added warnings for extendNodeEncodings. Seems we cannot do anything at the moment with the latter issue. |
This pull request adds Node.js version 4.0 testing.
I've noticed that the tests fail on io.js and Node 4.0.
There are two separate problems here.
The first problem is that the
iconv
package (needed for testing) won't build.I've thought (initially) that these engine versions need a newer toolchain environment setting (
CXX=g++-4.8
) as implied by travis-ci/travis-ci#4771 and netiam/experiments@b700b51, but the actual problem seems to be something else.The second problem is that the iconv-lite's behaviour is itself not quite right.
I have performed some manual testing on Windows in Node.js v4.0.0, and the results don't seem correct:
The Pile of Poo Test™ seems to fail.
The results of such test were good enough in Node.js v0.12.x and v0.10.x where the result of
Buffer('\uD83D\uDCA9', 'cp866').toString('cp866')
was'??'
(i.e. one question mark for each half of the surrogate pair).