Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving some memory for echo. #6

Closed
wants to merge 1 commit into from
Closed

Conversation

dseguy
Copy link

@dseguy dseguy commented May 19, 2015

No description provided.

@nicktacular
Copy link

See serbanghita/Mobile-Detect#403

@ashur
Copy link
Owner

ashur commented May 19, 2015

Hi @dseguy!

I don't anticipate Pug output ever reaching the kind of scale where optimizing echo will make any discernible difference. Moreover, I'm seeing similar performance as @nicktacular with more modern versions of PHP: concatenation actually seems to perform better than passing each string as a parameter.

I appreciate your effort to help improve this project, but for now I'm going to leave things as they are.

@ashur ashur closed this May 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants