Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Turkish translation #31

Merged
merged 6 commits into from
Dec 6, 2020
Merged

Add Turkish translation #31

merged 6 commits into from
Dec 6, 2020

Conversation

berkaygunduzz
Copy link
Contributor

I also want to translate help and about, how can i do?

@ashutoshgngwr
Copy link
Owner

Hi @berkaygunduzz!

Thank you for your contributions. I am still to review the PR but if you could enable "Allow edits from maintainers" option, I could push a commit containing necessary code to enable localization of those resources.

@berkaygunduzz
Copy link
Contributor Author

Allow edits is already enabled for PR, is there another thing i should do?

@ashutoshgngwr
Copy link
Owner

@berkaygunduzz yeah, sorry mistake on my part.

@berkaygunduzz
Copy link
Contributor Author

Do you want me to translate copyright?

@ashutoshgngwr
Copy link
Owner

@berkaygunduzz No. The copyright statement should remain as is.

@berkaygunduzz
Copy link
Contributor Author

Done, is there anything else i can help?

Copy link
Owner

@ashutoshgngwr ashutoshgngwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Great work! If you want, you could help in translating Noice to Turkish.

@ashutoshgngwr ashutoshgngwr merged commit 15ad5a2 into ashutoshgngwr:master Dec 6, 2020
@berkaygunduzz
Copy link
Contributor Author

Sure, i will work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants