-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Conversation
Apologies for the extremely late reply. Have you seen #1850? I think there is a lot of overlapping func. |
It's quite a simple change really, just adding a new event type that can be emitted by bot-type plugins (telegram, IRC, etc) Wasn't sure how well it would merge with the new code. The remote logging feels like a bit of a hack tbh, wasn't sure of the best way to implement. However being able to emit commands to Gekko is pretty useless unless there's a way for Gekko to respond! This functionality is super useful in my current setup but understand if there's overlaps with other PR's |
Hi Zappra, I downloaded your clone and wanted to try your telegram out and tried to run gekko and am receiving the following error with the telegrambot. |
@whoodat Hi Sorry for late reply, I haven't seen that error before, have you installed tgfancy? As for commands supported, it's up to your strategy how you implement them. All the bot does is tokenise command and argument strings. Due to real world commitments haven't got a lot of time to work on Gekko atm... hope this helps |
@zappra I installed the npm tgfancy and I am sitll getting the same error. It seems to get very upset with the telegrambot for w/e reason: Unhandled rejection Error: 404 {"ok":false,"error_code":404,"description":"Not Found"} |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If you feel this is very a important issue please reach out the maintainer of this project directly via e-mail: gekko at mvr dot me. |
This adds two new features: command events and remote logging
Plugins like the telegram bot offer a window to communicate with Gekko but with limited utility.
This PR adds a new 'command' event type to allow telegram (or other similar plugins) to emit commands to other plugins, the core trading logic and the currently running strategy.
This opens up a bunch of opportunities, like manual buys/sells, querying internal strategy state, setting strategy parameters on the fly, etc
This PR also adds a new 'remote' log channel. Plugins can register themselves as a remote logger, which will then receive any messages sent with log.remote. This allows two way comms with command emitting modules and eg. the running strategy.
An example strategy is included that simply responds to 'help', 'buy' and 'sell' commands.
Not sure how easy this is to merge against recent changes to the core trading logic!
This PR changes telegrambot to use tgfancy which includes, amongst other things, guaranteed ordering of submitted messages