Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: plugin protocol #119

Merged
merged 1 commit into from
Jan 20, 2022
Merged

bump: plugin protocol #119

merged 1 commit into from
Jan 20, 2022

Conversation

f0rmiga
Copy link
Contributor

@f0rmiga f0rmiga commented Jan 19, 2022

We missed bumping the protocol version.

alexeagle
alexeagle approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still curious what we can do to verify our versioning is right so it's not a "remember to"
maybe when I get back into this code some more :)

@f0rmiga
Copy link
Contributor Author

f0rmiga commented Jan 20, 2022

Agree. We need a better story. Feel free to dive into it. If you don't get to it, I will at some point. I just think that our other tasks are more important at this time - and I may be wrong.

@f0rmiga f0rmiga merged commit 4614f4a into main Jan 20, 2022
@f0rmiga f0rmiga deleted the f0rmiga/bump-plugin-protocol branch January 20, 2022 00:23
@f0rmiga
Copy link
Contributor Author

f0rmiga commented Jan 20, 2022

Created #120 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@JesseTatasciore JesseTatasciore Awaiting requested review from JesseTatasciore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@f0rmiga @alexeagle