feat(help): Add target-syntax help topic #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
force-pushed
the
target-syntax
branch
from
bc3c87e
to
62b071d
Compare
f0rmiga
reviewed
Sep 4, 2021
cmd/aspect/root.go
Outdated
| @@ -37,7 +38,7 @@ func NewRootCmd(streams ioutils.Streams, defaultInteractive bool) *cobra.Command | |||
| var interactive bool | |||
| cmd.PersistentFlags().StringVar(&cfgFile, "config", "", "config file (default is $HOME/.aspect.yaml)") | |||
| cmd.PersistentFlags().BoolVar(&interactive, "interactive", defaultInteractive, "Interactive mode (e.g. prompts for user input)") | |||
|
|
|||
There was a problem hiding this comment.
Seems like your Go extension is not formatting the file automatically?
There was a problem hiding this comment.
I'm more interested in what gofmt is doing in the pre-commit...
% pre-commit run --all-files
go fmt...................................................................Failed
- hook id: go-fmt
- exit code: 1
Go files must be formatted with gofmt. Please run:
bazel run -- @go_sdk//:bin/gofmt -w /Users/alexeagle/Projects/aspect-cli/docs/help/topics/main.go
Go files must be formatted with gofmt. Please run:
bazel run -- @go_sdk//:bin/gofmt -w /Users/alexeagle/Projects/aspect-cli/cmd/aspect/root.g
I'll run those and keep an eye on this, if it's not triggering on the right files...
alexeagle
force-pushed
the
target-syntax
branch
from
62b071d
to
86eb8df
Compare
f0rmiga
approved these changes
Sep 4, 2021
|
Oh this is a first-class verb? I was expecting it under |
|
It's not first class, only shows under help, because it has no Run. It's a cobra thing. See the link I put there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.