build: allow PRs from forks #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jbedard
force-pushed
the
pr-forks
branch
16 times, most recently
from
e94b308
to
4f4137f
Compare
jbedard
commented
Feb 3, 2022
|
|
||
| git diff "origin/$1..origin/$2" --name-only | while read -r file; do | ||
| for file in "$@"; do | ||
|
|
There was a problem hiding this comment.
fwiw if I put echo "file: $file" here it does correctly loop over each file in the commit
There was a problem hiding this comment.
this is the same as the PR but with the echo: https://github.com/aspect-build/aspect-cli/runs/5057836349
f0rmiga
suggested changes
Feb 3, 2022
jbedard
force-pushed
the
pr-forks
branch
9 times, most recently
from
2928bbb
to
19829f1
Compare
jbedard
force-pushed
the
pr-forks
branch
17 times, most recently
from
9aa9192
to
96595e8
Compare
f0rmiga
reviewed
Feb 3, 2022
f0rmiga
reviewed
Feb 3, 2022
f0rmiga
approved these changes
Feb 3, 2022
jbedard
force-pushed
the
pr-forks
branch
4 times, most recently
from
9378f46
to
6bc9f83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.