test: add PluginSystem.Configure() tests #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
commented
Feb 11, 2022
jbedard
force-pushed
the
plugin-configure-tests
branch
from
4459afe
to
13c1836
Compare
jbedard
force-pushed
the
plugin-configure-tests
branch
4 times, most recently
from
9b146c3
to
dacbf03
Compare
f0rmiga
suggested changes
Feb 14, 2022
jbedard
force-pushed
the
plugin-configure-tests
branch
5 times, most recently
from
4a05219
to
8e65f30
Compare
jbedard
force-pushed
the
plugin-configure-tests
branch
7 times, most recently
from
5819d20
to
5bcc9fa
Compare
jbedard
force-pushed
the
plugin-configure-tests
branch
2 times, most recently
from
32d689d
to
9d8658f
Compare
f0rmiga
suggested changes
Feb 24, 2022
jbedard
force-pushed
the
plugin-configure-tests
branch
from
9d8658f
to
9b1c784
Compare
f0rmiga
reviewed
Feb 24, 2022
| } | ||
|
|
||
| p1 := plugin_mock.NewMockPlugin(ctrl) | ||
| p1.EXPECT().Setup(gomock.Any()) |
There was a problem hiding this comment.
In a follow-up PR, it would be nice to be explicit about what the Setup takes. I.e. testing that it's getting called with the expected args.
There was a problem hiding this comment.
I've updated some of them, but this specific one accepts an array of bytes which is pretty awkward. I think I'd only want to verify the bytes are correct in a test explicitly testing that, to avoid the "data => bytes" logic being repeated everywhere.
f0rmiga
reviewed
Feb 24, 2022
pkg/plugin/system/system_test.go
Outdated
| var stdout strings.Builder | ||
| streams := ioutils.Streams{Stdout: &stdout, Stderr: &stdout} | ||
|
|
||
| pluginProperties := make(map[string]interface { // foo: {}, |
jbedard
force-pushed
the
plugin-configure-tests
branch
from
37366a6
to
33f1f94
Compare
f0rmiga
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP with ugly unformulated code until #135 is merged, but let me know if you have any suggestionsThis could be merged before #135 now. Either way there will be conflicts so doesn't matter which merges first 🤷This PR currently includes #150