feat: fetch flags from bazel help as proto #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattem
commented
Sep 7, 2021
| @@ -0,0 +1,600 @@ | |||
| package bazel | |||
There was a problem hiding this comment.
This likely needs a different license header stamped in?
There was a problem hiding this comment.
yeah, and/or a vendor folder like Go idiom prescribes
mattem
commented
Sep 7, 2021
go.bzl
Outdated
| @@ -1033,10 +1033,10 @@ def deps(): | |||
| ) | |||
| go_repository( | |||
| name = "org_golang_x_tools", | |||
| build_directives = ["gazelle:exclude **/testdata/**/*"], | |||
There was a problem hiding this comment.
Finally, Gazelle is starting to ignore testdata.
alexeagle
reviewed
Sep 7, 2021
pkg/bazel/flags.go
Outdated
| func (b *Bazel) Flags() map[string]*FlagInfo { | ||
| helpCmdBuffer := new(bytes.Buffer) | ||
|
|
||
| if _, err := b.RunCommand([]string{"help", "flags-as-proto"}, helpCmdBuffer); err != nil { |
There was a problem hiding this comment.
TODO to memoize the flags keyed on the bazel version
alexeagle
approved these changes
Sep 7, 2021
mattem
force-pushed
the
flags_as_proto
branch
from
d309c13
to
6a51191
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to fetch all the flags from
bazel help flags-as-proto.This includes a vendored
pkg/bazel/bazelisk.gofile as a small tweak to the exposed API is required to pass in the stream on which to write the response.Includes the generated
flags.pb.gofile so my editor was happy, I'll add agenerated_file_testif this is an okay approach. (but I like the IDE with no red squiggles)I'd like some help with line 32 in
pkg/bazel/flags.go, it always raises an error, but the unmarshalled proto is fine :/