refactor: check in generated Go protos #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
force-pushed
the
checkin_proto
branch
2 times, most recently
from
2f49ba6
to
b91744f
Compare
This allows the editor to show type-hints and completions when working with Bazel. It's especially important for downstream plugin authors who use standard Go tooling to fetch the SDK and need a working editor.
alexeagle
force-pushed
the
checkin_proto
branch
from
b91744f
to
0e87568
Compare
kormide
reviewed
Mar 15, 2022
Avoids gazelle issue where map_kind only maps what it writes, not what it understands
alexeagle
force-pushed
the
checkin_proto
branch
from
c41530d
to
f6e3a9a
Compare
f0rmiga
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the editor to show type-hints and completions when working with Bazel.
It's especially important for downstream plugin authors who use standard Go tooling to fetch the SDK and need working editor help.