Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid re-entrance #221

Merged
merged 1 commit into from
Jul 13, 2022
Merged

feat: avoid re-entrance #221

merged 1 commit into from
Jul 13, 2022

Conversation

alexeagle
Copy link
Member

If the aspect-build/bazel fork is chosen by the first line in .bazelversion, then aspect-cli will try to call itself.
Instead it can provide the second line of the file in this case when calling our nested bazelisk

If the aspect-build/bazel fork is chosen by the first line in .bazelversion, then aspect-cli will try to call itself.
Instead it can provide the second line of the file in this case when calling our nested bazelisk
@alexeagle
Copy link
Member Author

Manually tested that this works, by publishing a fake release at https://github.com/aspect-build/bazel/releases/tag/0.5.1
and then using .bazelversion file

aspect-build/0.5.1
5.0.0

@alexeagle alexeagle merged commit 6ae8e79 into main Jul 13, 2022
@alexeagle alexeagle deleted the second_line branch July 13, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants