feat: build command #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
f0rmiga
commented
Sep 17, 2021
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
This allows `go mod tidy` to run successfully while keeping Gazelle happy. Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
alexeagle
approved these changes
Sep 17, 2021
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
f0rmiga
commented
Sep 17, 2021
Comment on lines
+39
to
+40
| SilenceUsage: true, | ||
| SilenceErrors: true, |
There was a problem hiding this comment.
@alexeagle I'm not entirely sure if we want this here at the root cmd or not. I'd be tempted to leave it in the root for now and see how other commands interact with it. Just something to be aware of.
cc @mattem
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
alexeagle
reviewed
Sep 17, 2021
| Not licensed for re-use. | ||
| */ | ||
|
|
||
| package aspecterrors |
There was a problem hiding this comment.
don't we have to change the Bazel Spawner interface to return this error type?
There was a problem hiding this comment.
No. The ExitError satisfies the default error interface. The change I made to the main func checks whether the error contains the exit code or not. Also, we cannot change the signature of the Run method since it has to match the signature defined by cobra for the RunE field in the Command struct.
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces the
aspect buildcommand that performs a simplebazel buildwithout any flags.Test plan
aspect build //....