feat: add clean command #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0rmiga
reviewed
Sep 18, 2021
f0rmiga
reviewed
Sep 24, 2021
cmd/aspect/build/build.go
Outdated
| @@ -29,7 +29,7 @@ func NewBuildCmd( | |||
|
|
|||
| cmd := &cobra.Command{ | |||
| Use: "build", | |||
| Short: "Builds the specified targets, using the options.", | |||
| Short: "Builds the specified targets, using the options", | |||
There was a problem hiding this comment.
Why remove the punctuation? The documentation lacks it, then. I don't get the tendency toward wrong grammar.
There was a problem hiding this comment.
meh, it's my preference for keeping lines shorter on the terminal, and also this is a sentence fragment since it doesn't have a subject. But consistency with bazel command is fine, and it does print periods here.
There was a problem hiding this comment.
When it gets into the markdown, it does have a subject, and it's called implied subject (I had to take a look into the English name since I only knew it in Portuguese).
f0rmiga
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.