Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use cobra string flags for Bazel boolean flags so a value of "no" is not a parsing failure #293

Merged
merged 1 commit into from
Oct 5, 2022
Merged

fix: use cobra string flags for Bazel boolean flags so a value of "no" is not a parsing failure #293

merged 1 commit into from
Oct 5, 2022

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Oct 5, 2022 •
edited
Loading

Cobra flag parsing can't handle "no" for boolean flags so we need to use cobra string flags for Bazel boolean flags

Fixes #287

@gregmagolan gregmagolan changed the title fix: use String flags for bazel boolean flags fix: use cobra string flags for Bazel boolean flags so a value of "no" is not a parsing failure Oct 5, 2022
@gregmagolan gregmagolan marked this pull request as ready for review October 5, 2022 16:09
f0rmiga
f0rmiga approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@f0rmiga f0rmiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, it doesn't even accept --bool-flag=false.

@f0rmiga f0rmiga merged commit 769af47 into main Oct 5, 2022
@f0rmiga f0rmiga deleted the fix_bool_flags branch October 5, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f0rmiga f0rmiga f0rmiga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cobra flag parsing can't handle "no" but it should
2 participants
@gregmagolan @f0rmiga