Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert "feat: add //install target for installing the Aspect CLI on the system" #307

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

cgrindel
Copy link
Contributor

Reverts #298

@cgrindel cgrindel self-assigned this Oct 11, 2022
@cgrindel cgrindel enabled auto-merge (rebase) October 11, 2022 20:05
@alexeagle
Copy link
Member

Do we need this install tool to be in the silo repo?

@cgrindel
Copy link
Contributor Author

It is for CLI only. I thought the source of truth is silo. Also, this PR may be moot given our decision to just do a binary bottle formula for Homebrew.

@alexeagle
Copy link
Member

Yeah it seems like the install target is a false start, since we distribute a binary

@cgrindel cgrindel merged commit 0250f4f into main Oct 11, 2022
@cgrindel cgrindel deleted the revert-298-install_target branch October 11, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants