chore(copybara): sync commits from Aspect-internal silo #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4.2.2 just adds the coverage command which was missing. We don't use that in silo but cut a release to exercise the release process in silo & update commit followed by copybara & a release in OSS GitOrigin-RevId: f3ca1f717a684877b857a604fd622137384ef69a
Fixes #753. Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com> GitOrigin-RevId: 028ee44620aae0f6b0f9e184a06639a4827066ea
gazelle seems to treat the //release package differently 🤷 GitOrigin-RevId: 62b17cc8208d71e60ee80df0e5947f2e7d7cacad
…no]workspace_config and --aspect:[no]home_config flags (#761) Config file is now loaded before cobra is configured so that we can check for a `version` config value in a follow-up. Configs are loaded in increasing preference. Options in later files can override a value form an earlier file if a conflict arises. Inspired by where Bazel looks for .bazelrc and how this is configured: https://bazel.build/run/bazelrc. I did not add a "system" config equivalent to the "system" bazelrc found at `/etc/bazel.bazelrc`. It could be easily added in the future with the pattern in place here. GitOrigin-RevId: b412d765d3a5a66cfe7c26247d305af001725d72
Turns out that viper does not do the right thing unless you set both `SetConfigName` without the extension and `SetConfigType` with extension 🤷 GitOrigin-RevId: a515b15a0c4126327baaa516b2ef1eeab2f48bca
Short-circuit the `--version` and `-v` special cases before we download plugins so it is fast and doesn't require any network access GitOrigin-RevId: aaf8a199878d6d28ed5a2d3ca16f868ea70dc9ea
…lags that expand to other flags (#762) Issue reported by Matt here https://aspect-build.slack.com/archives/C024P0WT7D4/p1668187960666339 GitOrigin-RevId: 5662ddf1599352bbc3ac1a4d7f3e875339ddf0b7
…f fetching aspect CLI (#765) GitOrigin-RevId: 0e2b5e815e3eb05eb9ccd7dd7c77d16b7d8b3e29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit range https://github.com/aspect-build/silo/compare/9210e09bd213e8461b1fe69b452a49c3a36e134c..f3ca1f717a684877b857a604fd622137384ef69a