Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(copybara): sync commits from Aspect-internal silo #349

Merged
merged 2 commits into from
Nov 17, 2022
Merged

chore(copybara): sync commits from Aspect-internal silo #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ec1d5c
chore(cli): make it more clear on how to install aspect on Linux (#811)
gregmagolan Nov 17, 2022
81a5adb
fix(cli): allow any execute bits to count as executable (#810)
gregmagolan Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ This installs the `aspect` command and also links it to `bazel`, just like the [

> We plan to have a standard "core" homebrew formula so this will just be `brew install aspect` in the future.

## Linux

On Linux, you can download the `aspect` binary on our [Releases](https://github.com/aspect-build/aspect-cli/releases) page and add it to your `PATH` manually. This also works on MacOS and Windows.

## Bazelisk

On any platform, so long as you already have [bazelisk] installed, you can have [bazelisk]
Expand Down
2 changes: 1 addition & 1 deletion pkg/bazel/bazelisk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ func (bazelisk *Bazelisk) maybeDelegateToWrapper(bazel string) string {
}

wrapper := filepath.Join(bazelisk.workspaceRoot, wrapperPath)
if stat, err := os.Stat(wrapper); err != nil || stat.IsDir() || stat.Mode().Perm()&0001 == 0 {
if stat, err := os.Stat(wrapper); err != nil || stat.IsDir() || stat.Mode().Perm()&0111 == 0 {
return bazel
}

Expand Down