Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixup release instructions for pushing tags #421

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Apr 9, 2023

Description

Current instructions are incorrect.

Type of change

  • Documentation (updates to documentation or READMEs)

Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's wrong with that bash shorthand notation? It means "last argument of prior command"

@gregmagolan
Copy link
Member Author

What's wrong with that bash shorthand notation? It means "last argument of prior command"

I don't know. It doesn't work for me.

gregs-mbp:aspect-cli greg$ git tag 6.6.6
gregs-mbp:aspect-cli greg$ echo $!
76802

Maybe it is linux specific?

@gregmagolan
Copy link
Member Author

gregmagolan commented Apr 9, 2023

On noes... the stupid failing git describe --tags is back again,

//release/brew/tests:version_file_with_stamp_test                        FAILED in 0.3s
  /home/runner/.cache/bazel/_bazel_runner/8e9f7bf5c7ea7145245717c620f4b2bc/execroot/build_aspect_cli/bazel-out/k8-fastbuild/testlogs/release/brew/tests/version_file_with_stamp_test/test.log

if you look closely at the logs you'll see

fatal: No tags can describe 'a600aa03c1b7dbb3e01e4d2b9698d187cf79752f'.

which comes from

echo "STABLE_BUILD_SCM_TAG $(git describe --tags)"

in the workspace_status.sh script

@gregmagolan gregmagolan force-pushed the fixup_release_instructions branch 3 times, most recently from 6298ea3 to 7b9cd45 Compare April 9, 2023 16:51
@gregmagolan
Copy link
Member Author

gregmagolan commented Apr 10, 2023

Oh I see... the current token $! in the instructions is last PID.

Last arg is either !$ or $_... Updating to $_ since !$ is too easy to mixup with $! at a glance.

@gregmagolan gregmagolan merged commit e95892c into main Apr 10, 2023
@gregmagolan gregmagolan deleted the fixup_release_instructions branch April 10, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants