chore(copybara): sync commits from Aspect-internal silo #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We now have Aspect Workflows Buildkite, CircleCI and GitHub Actions integrations on AWS turned on for this repository 🌮 |
jbedard
approved these changes
Jun 2, 2023
Fix #422 GitOrigin-RevId: d009c6c127f4c4e887c2b523d9e1caf477c34183
gregmagolan
force-pushed
the
9E6ED7960E7C1C7500F98C1F23B6018B
branch
from
3c1a0ff
to
5a8e4fc
Compare
Ref #440 GitOrigin-RevId: d6167e5a5e99992dc56dc357bed110be7e1b8239
Add `js_custom[_test]_files` directives to generate custom targets in addition to the default library + tests targets.
Example:
```
# gazelle:js_custom_files {dirname}_po *.po.ts
# gazelle:js_custom_test_files e2e *.e2e.ts
```
will generate:
```
ts_project(
name = "{dirname}_po",
srcs = ["a.po.ts"],
)
ts_project(
name = "e2e",
srcs = ["b.e2e.ts"],
testonly = True,
)
```
Close #427
GitOrigin-RevId: d982ebac0091253dc35302a9a580d8ec74cccf4d
Upgrades to the latest version of msolo/jsonr which the aspect-cli repo also has, this changes the error strings with invalid json requiring the test change. ### Type of change - Chore (any other change that doesn't affect source or test files, such as configuration) ### Test plan - Covered by existing test cases GitOrigin-RevId: cf991558bf10e1550d4ecbf95136e861a9aebf9b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit range https://github.com/aspect-build/silo/compare/72e57e397e370ffeb5b4f8de4dc002d604daf782..cf991558bf10e1550d4ecbf95136e861a9aebf9b