chore(copybara): sync commits from Aspect-internal silo #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les (#3945) GitOrigin-RevId: 076883744d9bd5fe16cee0ac67022bf7e1ac81ac
Basic tests primarily just to verify gazelle languages can be enabled and are opt-in. ### Type of change - Chore (any other change that doesn't affect source or test files, such as configuration) GitOrigin-RevId: 316bad73664d4e33027ace700dda7bde2df9b1ca
Followed the pattern of how `outputs` accepts all `aquery` flags. ### Type of change - Bug fix (change which fixes an issue) ### Test plan - Manual testing; please provide instructions so we can reproduce: `bazel lint --config foo //...` after adding a config named foo GitOrigin-RevId: 5f59d238369281dd50354905f4b0db15ab2aa195
…-sitter (#4008) Primarily for smacker/go-tree-sitter#128, but also updates the js + ts grammars. ### Type of change - Bug fix (change which fixes an issue) ### Test plan - New test cases added GitOrigin-RevId: 869c0ae23c9c8862020002ddfd6c46c5e01b1785
…globs (#3975) Fixes #565 ### Type of change - Bug fix (change which fixes an issue) - New feature or functionality (change which adds functionality) ### Test plan - Covered by existing test cases - New test cases added GitOrigin-RevId: 727d84936802ff5c8632695c695d7e15d000a341
### Type of change - Bug fix (change which fixes an issue) **For changes visible to end-users** No logging to stdout when configuring logger. ### Test plan - Manual testing; please provide instructions so we can reproduce: GitOrigin-RevId: a9689470551535c3d0f988ad75c9bfcaacb01072
Switch to use a regex replace on the file URI. This allows us to not couple the mount path of the grpc socket to the CLI code. Part of #4051 --- ### Type of change - Refactor (a code change that neither fixes a bug or adds a new feature) ### Test plan - Manual testing; please provide instructions so we can reproduce: Not sure how to test this, here's a Go playground link of the similar code, https://go.dev/play/p/riRIz2Qgx3y GitOrigin-RevId: 9e7e1ec7bd5e338e52269aef3a3eead40981a9c0
…diff (#4064) Update some generic exit codes and add some new aspect-cli exit codes. Change the cli to return specific configure exit codes for different results. ### Type of change - New feature or functionality (change which adds functionality) ### Test plan - Covered by existing test cases - New test cases added - Manual testing: run the cli with combos of a) `--mode=diff|fix` b) BUILDs needing update vs already updated, then inspect the exit codes GitOrigin-RevId: 7617eed76930555eb7e6c9bb48feaa2a73f1cc63
When in `diff` or `print` mode it should only output the gazelle results, otherwise the outputted diff or printed BUILDs are invalid. The status/result messages should only be outputted in `fix` mode. ### Type of change - Bug fix (change which fixes an issue) ### Test plan - New test cases added GitOrigin-RevId: 1d9f030351cb49088f7258627de9e4278b13af14
After recently adding support for `srcs = glob([])` in addition to `srcs = ["strs", ...]` more warning started appearing when parsing those more complex expressions failed such as `srcs = AN_ARRAY`. ### Type of change - Bug fix (change which fixes an issue) ### Test plan - Manual testing; please provide instructions so we can reproduce: GitOrigin-RevId: 4958a3027885f44dabb3d3ca36bca09220614228
Like #3017 but without renovate making a mess of it. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> GitOrigin-RevId: 5b5e28338ca6497e6b2ac9325eb200498a5bbec9
GitOrigin-RevId: b198efa3bc966d920c908b76d38738de492ebc37
gregmagolan
force-pushed
the
9E6ED7960E7C1C7500F98C1F23B6018B
branch
from
7aa6779
to
7f1960b
Compare
gregmagolan
force-pushed
the
9E6ED7960E7C1C7500F98C1F23B6018B
branch
from
0a17583
to
73ec5c2
Compare
jbedard
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit range https://github.com/aspect-build/silo/compare/7a0d494caf2027b8d3130bdff88eeab67a3ed22b..076883744d9bd5fe16cee0ac67022bf7e1ac81ac