chore(copybara): sync commits from Aspect-internal silo #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So the next sync is cleaner GitOrigin-RevId: 2909828753235ea9424b43722c004e4b150869c3
…130) This is a large refactor to principally fix a subtle bug in MaybeReenterAspect where the exit code from the re-entrant process is not propagated to the exit code of the parent process. TL;DR here is that the `bazelisk.Run` function is updated to not return both an exitCode and err but rather just an error. If there is an exitCode to propagate from Bazel then it is done so via the ExitError struct at that point. This change unwinds many of the places that ExitError is created from combining the excitCode and error. --- ### Type of change - Bug fix (change which fixes an issue) **For changes visible to end-users** - Suggested release notes are provided below: Aspect CLI will now correctly propagate the exit code of the nested Aspect CLI process if a child Aspect CLI is spawned with the re-entry logic. ### Test plan - New test cases added GitOrigin-RevId: c7f7ca09030120a76a6cd5ffd06c93da95d06eda
GitOrigin-RevId: 33f06b8ffa97a31575e18cf635ef33e7d7bcb8fe
Adds `lint --fix|diff|report` bool args to apply fixes or output a diff, while keeping the existing report output as the default. ### Type of change - New feature or functionality (change which adds functionality) ### Test plan - Manual testing GitOrigin-RevId: ab7514c87f5fba12d0b7e8899cc8e51f47777657
alexeagle
requested review from
jbedard and
gregmagolan
and removed request for
jbedard
gregmagolan
approved these changes
Jan 4, 2024
alexeagle
force-pushed
the
8AEF12339515D0A47D3EA1E9D42A18D8
branch
from
6187081
to
6c79a52
Compare
alexeagle
force-pushed
the
8AEF12339515D0A47D3EA1E9D42A18D8
branch
from
6c79a52
to
8d23517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit range https://github.com/aspect-build/silo/compare/b198efa3bc966d920c908b76d38738de492ebc37..2909828753235ea9424b43722c004e4b150869c3