chore(copybara): sync commits from Aspect-internal silo #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitOrigin-RevId: 7458fd02f4dbaa0d24160c0de1f370710fedb090
GitOrigin-RevId: fe985d28f0ec9d85bdb0d6d51e6fef046744e63e
GitOrigin-RevId: f5558f5f6c846ce4d067d6513240eeb12d6ad778
GitOrigin-RevId: de9804794b8b66dd3fa80df4d2b53dcf6a14a00a
gregmagolan
approved these changes
Mar 7, 2024
alexeagle
added a commit
that referenced
this pull request
Mar 18, 2024
Make the transform simpler by removing special cases: - moving the "help topics" docs under cli/core, give up on publishing them on the public site for now. - move one import to a separate block so it doesn't get re-ordered after rewriting our go imports - express the transforms as silo -> OSS which is the way we think about it now. Originally when I wrote this, the direction was opposite since we were bringing the OSS repo into silo. - move the go_generated_sources helper Added a couple more copybara workflows that let me test locally and iron out the diffs. --- ### Type of change - Refactor (a code change that neither fixes a bug or adds a new feature) ### Test plan - Manual testing; please provide instructions so we can reproduce: Run a sync from this branch, it's totally clean with no manual fixups: #651 Also ran the two added workflows and checked in meld that the transforms line up in both directions. Did not test the import_pr workflow yet, will do after this lands. GitOrigin-RevId: bfb27b61d7c85691a776d1db852da03b5617ac36
alexeagle
added a commit
that referenced
this pull request
Mar 18, 2024
Make the transform simpler by removing special cases: - moving the "help topics" docs under cli/core, give up on publishing them on the public site for now. - move one import to a separate block so it doesn't get re-ordered after rewriting our go imports - express the transforms as silo -> OSS which is the way we think about it now. Originally when I wrote this, the direction was opposite since we were bringing the OSS repo into silo. - move the go_generated_sources helper Added a couple more copybara workflows that let me test locally and iron out the diffs. --- ### Type of change - Refactor (a code change that neither fixes a bug or adds a new feature) ### Test plan - Manual testing; please provide instructions so we can reproduce: Run a sync from this branch, it's totally clean with no manual fixups: #651 Also ran the two added workflows and checked in meld that the transforms line up in both directions. Did not test the import_pr workflow yet, will do after this lands. GitOrigin-RevId: bfb27b61d7c85691a776d1db852da03b5617ac36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit range https://github.com/aspect-build/silo/compare/88d14c9d79fe9fbd94893454a84ee527c53ebbae..7458fd02f4dbaa0d24160c0de1f370710fedb090
Keeping silo gazelle-clean introduced this missing bzl_library from previous sync.