chore(copybara): sync commits from Aspect-internal silo #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes a refactoring to split the BEP code into a separate file. Adds a parser for the ESlint format to SARIF for use with Marvin. Fixes #663 Fixes #556 --- ### Type of change - New feature or functionality (change which adds functionality) **For changes visible to end-users** - Relevant documentation has been updated ### Test plan - Manual testing; please provide instructions so we can reproduce: Ran `bazel lint` on code in Silo. GitOrigin-RevId: 31c5662a625e7d7076fb4a58b55947fdedaaee36
Updates the bats framework deps. --- ### Type of change - Chore (any other change that doesn't affect source or test files, such as configuration) ### Test plan - Covered by existing test cases GitOrigin-RevId: 7e9d33ba520a8057ed74e194eb003e9928771ab2
Refactor existing tests into a common Bazel package FYI @thesayyn since I'm moving your bats setup a bit. --- ### Type of change - Chore (any other change that doesn't affect source or test files, such as configuration) ### Test plan - New test cases added GitOrigin-RevId: 7ed57e6976ff8a9ceddd1577ed039aa9a7ff3c87
### Type of change - Chore (any other change that doesn't affect source or test files, such as configuration) ### Test plan - Covered by existing test cases GitOrigin-RevId: b0003fcb151e97e297fd59c89fe327c87fc62e97
### Type of change - Bug fix (change which fixes an issue) ### Test plan - New test cases added GitOrigin-RevId: 19e7fa7bacbc2477f514d36051a65e335f1fd5d4
This was done as a prefactor to the gazelle starlark API, just making things more generic where today it was written specifically for js + kotlin. ### Type of change - Refactor (a code change that neither fixes a bug or adds a new feature) ### Test plan - Covered by existing test cases GitOrigin-RevId: fe36340578ba2221a5dc5c5a222c54ed1c039ec6
GitOrigin-RevId: 3e40530eb0554208b363f73d71ec1fb71bd12996
Fix #657 --- ### Type of change - Bug fix (change which fixes an issue) ### Test plan - New test cases added GitOrigin-RevId: f8f960e20b10051a0bc27c0777108463c10e82c8
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit range https://github.com/aspect-build/silo/compare/bd58659a160ced377509a064ee6b3c443a6a3179..31c5662a625e7d7076fb4a58b55947fdedaaee36
Fixes #673