chore(copybara): sync commits from Aspect-internal silo #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jbedard
force-pushed
the
31E4ABF721D0FDAF3FAADE0D116E4447
branch
3 times, most recently
from
a54a6a5
to
d8157af
Compare
alexeagle
approved these changes
May 13, 2024
Missing documentation for js gazelle attributes. GitOrigin-RevId: 09f8f787dd169aad495660bde82205f5a5a583a5
Ref bazel-contrib/bazel-gazelle#853 Changes are visible to end-users: no GitOrigin-RevId: ac0cbd1d572d35c14f494a40fd6ed6ebf8f3af19
--- - Searched for relevant documentation and updated as needed: no - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes The exit code from `aspect lint` is now `1` if any of the exit codes from the linters that were run were non-zero. - Manual testing; please provide instructions so we can reproduce: ``` bazel build cli && bazel-bin/cli/core/cmd/aspect/aspect_/aspect lint ... ... $ echo $? 1 ``` GitOrigin-RevId: cd01276083bff737c05dbb9c5db34ff9c02d68f6
Augmented the build.rs script to make serde bindings be included for every generated .rs file --- ### Changes are visible to end-users: no ### Test plan - New test cases added GitOrigin-RevId: c39444fbabb7818d0033f0aaee0c95ca1ce7f096
jbedard
force-pushed
the
31E4ABF721D0FDAF3FAADE0D116E4447
branch
from
d8157af
to
7cfe909
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit range https://github.com/aspect-build/silo/compare/cf6d1d244bbd38af13f5e42780e7d7f3ccd196a2..cd01276083bff737c05dbb9c5db34ff9c02d68f6