Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: sync commits from Aspect-internal silo #697

Merged
merged 4 commits into from
May 20, 2024

Conversation

Removes the goembed folder that lived in silo.
Allows us to update the scaffold independently of CLI releases.

---

### Changes are visible to end-users: yes

- Searched for relevant documentation and updated as needed: yes
- Breaking change (forces users to change their own code or config): no
- Suggested release notes appear below: yes

New workspace creation with `aspect init` is now more full-featured:
- Uses an external repository which can be updated without CLI release
- That repo stamps out an application with optional JS&TS and/or Python
support; more languages to come
- It optionally includes a stamping setup
- It optionally installs rules_lint with a format target and linters for
the selected languages

### Test plan

- Covered by existing test cases

GitOrigin-RevId: fe5da6545697edbe3546661094696a8854db5308
GitOrigin-RevId: 2a0844d0cd489ff36798e2a5e80ead705e38e129
Makes the copybara sync clean again

GitOrigin-RevId: 4af699a402a55d6825e881063c5b297c9c700042
Copy link

aspect-workflows bot commented May 20, 2024

Test

8 test targets passed

Targets
//docs:check_aspect_init.md [k8-fastbuild]               222ms
//integration_tests/aspect:configure_test [k8-fastbuild] 31s
//integration_tests/aspect:flags_test [k8-fastbuild]     1m 13s
//integration_tests/aspect:info_test [k8-fastbuild]      24s
//integration_tests/aspect:init_test [k8-fastbuild]      47s
//integration_tests/aspect:lint_test [k8-fastbuild]      57s
//integration_tests/aspect:reenter_test [k8-fastbuild]   45s
//integration_tests/aspect:version_test [k8-fastbuild]   33s

Total test execution time was 5m 12s. 186 tests (95.9%) were fully cached saving 55s.


Buildifier      Format

@alexeagle alexeagle enabled auto-merge (rebase) May 20, 2024 21:00
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@alexeagle alexeagle merged commit dcfe3f0 into main May 20, 2024
9 checks passed
@alexeagle alexeagle deleted the 0EBA9B56DBA598CAE6CF22C96EF3333D branch May 20, 2024 21:21
gregmagolan pushed a commit that referenced this pull request May 20, 2024
---

### Changes are visible to end-users: no

### Test plan

- Manual testing; please provide instructions so we can reproduce:
sync to #697 looks right

GitOrigin-RevId: d0125843e886e7dfd7b2d124e85cd3259c5d6ad5
gregmagolan pushed a commit that referenced this pull request May 21, 2024
---

### Changes are visible to end-users: no

### Test plan

- Manual testing; please provide instructions so we can reproduce:
sync to #697 looks right

GitOrigin-RevId: d0125843e886e7dfd7b2d124e85cd3259c5d6ad5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants