refactor: use buildeventstream alias for clarity #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
alexeagle
reviewed
Nov 18, 2021
|
|
||
| alias( | ||
| name = "proto", | ||
| actual = "//third-party/github.com/bazelbuild/bazel/src/main/java/com/google/devtools/build/lib/buildeventstream/proto", |
There was a problem hiding this comment.
nit: I think it's also fine for us to vendor the file itself here, the third-party directory structure isn't mandated anywhere
There was a problem hiding this comment.
Yeah, I believe there's no obligation to do the way I did. Still, I like to keep it there as it makes it clear the file is vendored and not authored by us.
alexeagle
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the buildeventstream proto is vendored and lives under third-party, we do some workarounds to make it appear to come from //bazel/buildeventstream/proto.
We enforce it with Gazelle now. Makes it simpler to reason about when importing
aspect.build/cli/bazel/buildeventstream/proto.