Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugins): Wire the test verb up to the CLI plugin infrastructure #91

Merged
merged 2 commits into from
Jan 7, 2022
Merged

feat(plugins): Wire the test verb up to the CLI plugin infrastructure #91

merged 2 commits into from
Jan 7, 2022

Conversation

JesseTatasciore
Copy link
Member

@JesseTatasciore JesseTatasciore commented Jan 5, 2022 •
edited
Loading

plugins-via-test

@JesseTatasciore JesseTatasciore self-assigned this Jan 5, 2022
@JesseTatasciore JesseTatasciore linked an issue Jan 5, 2022 that may be closed by this pull request
Allow plugins to be called when using the test verb #90
Closed
f0rmiga
f0rmiga suggested changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@f0rmiga f0rmiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

pkg/aspect/test/test_test.go Show resolved Hide resolved
pkg/plugin/sdk/v1alpha1/plugin/grpc.go Outdated Show resolved Hide resolved
@JesseTatasciore JesseTatasciore force-pushed the jtatasciore-allow-test-verb-to-use-plugins branch from 8bab132 to 8f095be Compare January 7, 2022 17:44
@JesseTatasciore JesseTatasciore merged commit c3cf26f into main Jan 7, 2022
@JesseTatasciore JesseTatasciore deleted the jtatasciore-allow-test-verb-to-use-plugins branch January 7, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f0rmiga f0rmiga f0rmiga approved these changes

Assignees

@JesseTatasciore JesseTatasciore

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow plugins to be called when using the test verb
2 participants
@JesseTatasciore @f0rmiga