Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: setup checkstyle linter for Java #346

Merged
merged 1 commit into from
Sep 6, 2024
Merged

chore: setup checkstyle linter for Java #346

merged 1 commit into from
Sep 6, 2024

Conversation

alexeagle
Copy link
Member

Changes are visible to end-users:no

Test plan

  • Manual testing; please provide instructions so we can reproduce:
bazel lint logger/client/...

Lint results for //logger/client/src/build/aspect:JavaLoggingClientLibrary:

{
  "$schema": "https://raw.githubusercontent.com/oasis-tcs/sarif-spec/master/Schemata/sarif-schema-2.1.0.json",
  "version": "2.1.0",
  "runs": [
    {
      "tool": {
        "driver": {
          "downloadUri": "https://github.com/checkstyle/checkstyle/releases/",
          "fullName": "Checkstyle",
          "informationUri": "https://checkstyle.org/",
          "language": "en",
          "name": "Checkstyle",
          "organization": "Checkstyle",
          "rules": [
          ],
          "semanticVersion": "10.17.0",
          "version": "10.17.0"
        }
      },
      "results": [

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Aug 29, 2024 •
edited
Loading

Test

All tests were cache hits

22 tests (100.0%) were fully cached saving 5s.

Lint

@alexeagle
Copy link
Member Author

I'm not sure I should merge this as-is, since anyone running bazel lint ... in the 201 course will see sarif on their terminal, with this version of Aspect CLI

jbedard pushed a commit to aspect-build/aspect-cli that referenced this pull request Sep 3, 2024
@JesseTatasciore @jbedard
feat(lint): Show human readable output by default (#6625)
40435a9 
We were always showing the linting sarif output from the CLI. Instead
default to the human readable version and request the machine readable
one from workflows

---

### Changes are visible to end-users: yes

- Searched for relevant documentation and updated as needed: no
- Breaking change (forces users to change their own code or config): yes
- Suggested release notes appear below: yes

The CLI now outputs linting results in human readable form by default.
To get the machine readable version, use the `--machine` flag

### Test plan

- Manual testing; please provide instructions so we can reproduce:

Running against aspect-build/bazel-examples#346
with and without `--machine`

GitOrigin-RevId: b1915d8dc8b5406c7e09ed499a38792f4af10f42
jbedard pushed a commit to aspect-build/aspect-cli that referenced this pull request Sep 3, 2024
@JesseTatasciore @jbedard
feat(lint): Show human readable output by default (#6625)
a718d44 
We were always showing the linting sarif output from the CLI. Instead
default to the human readable version and request the machine readable
one from workflows

---

### Changes are visible to end-users: yes

- Searched for relevant documentation and updated as needed: no
- Breaking change (forces users to change their own code or config): yes
- Suggested release notes appear below: yes

The CLI now outputs linting results in human readable form by default.
To get the machine readable version, use the `--machine` flag

### Test plan

- Manual testing; please provide instructions so we can reproduce:

Running against aspect-build/bazel-examples#346
with and without `--machine`

GitOrigin-RevId: b1915d8dc8b5406c7e09ed499a38792f4af10f42
jbedard pushed a commit to aspect-build/aspect-cli that referenced this pull request Sep 4, 2024
@JesseTatasciore @jbedard
feat(lint): Show human readable output by default (#6625)
2cd5bc0 
We were always showing the linting sarif output from the CLI. Instead
default to the human readable version and request the machine readable
one from workflows

---

- Searched for relevant documentation and updated as needed: no
- Breaking change (forces users to change their own code or config): yes
- Suggested release notes appear below: yes

The CLI now outputs linting results in human readable form by default.
To get the machine readable version, use the `--machine` flag

- Manual testing; please provide instructions so we can reproduce:

Running against aspect-build/bazel-examples#346
with and without `--machine`

GitOrigin-RevId: b1915d8dc8b5406c7e09ed499a38792f4af10f42
jbedard pushed a commit to aspect-build/aspect-cli that referenced this pull request Sep 4, 2024
@JesseTatasciore @jbedard
feat(lint): Show human readable output by default (#6625)
a29ba57 
We were always showing the linting sarif output from the CLI. Instead
default to the human readable version and request the machine readable
one from workflows

---

- Searched for relevant documentation and updated as needed: no
- Breaking change (forces users to change their own code or config): yes
- Suggested release notes appear below: yes

The CLI now outputs linting results in human readable form by default.
To get the machine readable version, use the `--machine` flag

- Manual testing; please provide instructions so we can reproduce:

Running against aspect-build/bazel-examples#346
with and without `--machine`

GitOrigin-RevId: b1915d8dc8b5406c7e09ed499a38792f4af10f42
alexeagle pushed a commit to aspect-build/aspect-cli that referenced this pull request Sep 4, 2024
@JesseTatasciore @alexeagle
feat(lint): Show human readable output by default (#6625)
aebb041 
We were always showing the linting sarif output from the CLI. Instead
default to the human readable version and request the machine readable
one from workflows

---

- Searched for relevant documentation and updated as needed: no
- Breaking change (forces users to change their own code or config): yes
- Suggested release notes appear below: yes

The CLI now outputs linting results in human readable form by default.
To get the machine readable version, use the `--machine` flag

- Manual testing; please provide instructions so we can reproduce:

Running against aspect-build/bazel-examples#346
with and without `--machine`

GitOrigin-RevId: b1915d8dc8b5406c7e09ed499a38792f4af10f42
@alexeagle alexeagle merged commit b4e2ee9 into main Sep 6, 2024
17 checks passed
jbedard pushed a commit to aspect-build/aspect-cli that referenced this pull request Sep 27, 2024
@JesseTatasciore @jbedard
feat(lint): Show human readable output by default (#6625)
0678ba1 
We were always showing the linting sarif output from the CLI. Instead
default to the human readable version and request the machine readable
one from workflows

---

### Changes are visible to end-users: yes

- Searched for relevant documentation and updated as needed: no
- Breaking change (forces users to change their own code or config): yes
- Suggested release notes appear below: yes

The CLI now outputs linting results in human readable form by default.
To get the machine readable version, use the `--machine` flag

### Test plan

- Manual testing; please provide instructions so we can reproduce:

Running against aspect-build/bazel-examples#346
with and without `--machine`

GitOrigin-RevId: d5c11728f628d459d59d59251b84fe839fd2e5e4
jbedard pushed a commit to aspect-build/aspect-cli that referenced this pull request Sep 28, 2024
@JesseTatasciore @jbedard
feat(lint): Show human readable output by default (#6625)
361ceb9 
We were always showing the linting sarif output from the CLI. Instead
default to the human readable version and request the machine readable
one from workflows

---

- Searched for relevant documentation and updated as needed: no
- Breaking change (forces users to change their own code or config): yes
- Suggested release notes appear below: yes

The CLI now outputs linting results in human readable form by default.
To get the machine readable version, use the `--machine` flag

- Manual testing; please provide instructions so we can reproduce:

Running against aspect-build/bazel-examples#346
with and without `--machine`

GitOrigin-RevId: d5c11728f628d459d59d59251b84fe839fd2e5e4
jbedard pushed a commit to aspect-build/aspect-cli that referenced this pull request Sep 28, 2024
@JesseTatasciore @jbedard
feat(lint): Show human readable output by default (#6625)
7a51098 
We were always showing the linting sarif output from the CLI. Instead
default to the human readable version and request the machine readable
one from workflows

---

- Searched for relevant documentation and updated as needed: no
- Breaking change (forces users to change their own code or config): yes
- Suggested release notes appear below: yes

The CLI now outputs linting results in human readable form by default.
To get the machine readable version, use the `--machine` flag

- Manual testing; please provide instructions so we can reproduce:

Running against aspect-build/bazel-examples#346
with and without `--machine`

GitOrigin-RevId: d5c11728f628d459d59d59251b84fe839fd2e5e4
jbedard pushed a commit to aspect-build/aspect-cli that referenced this pull request Sep 28, 2024
@JesseTatasciore @jbedard
feat(lint): Show human readable output by default (#6625)
e61adf7 
We were always showing the linting sarif output from the CLI. Instead
default to the human readable version and request the machine readable
one from workflows

---

- Searched for relevant documentation and updated as needed: no
- Breaking change (forces users to change their own code or config): yes
- Suggested release notes appear below: yes

The CLI now outputs linting results in human readable form by default.
To get the machine readable version, use the `--machine` flag

- Manual testing; please provide instructions so we can reproduce:

Running against aspect-build/bazel-examples#346
with and without `--machine`

GitOrigin-RevId: d5c11728f628d459d59d59251b84fe839fd2e5e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesseTatasciore JesseTatasciore JesseTatasciore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @JesseTatasciore