Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump rules_oci from 1.8.0 to 2.0.0 in /oci_python_image #360

Conversation

ahans
Copy link
Contributor

@ahans ahans commented Sep 26, 2024

Docs over at rules_oci point here, but the current version is incompatible with the current version (oci_tarball was renamed). This PR updates the example.


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: no

Test plan

  • Covered by existing test cases
  • Manual testing; please provide instructions so we can reproduce:
bazel build //hello_world:image_load.tar

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2024

CLA assistant check
All committers have signed the CLA.

@ahans ahans force-pushed the feature/ahans/update-oci_python_image-to-rules_oci-2.0.0 branch from db706ba to 90ef628 Compare September 26, 2024 13:42
Copy link

aspect-workflows bot commented Sep 26, 2024

Test

All tests were cache hits

25 tests (100.0%) were fully cached saving 11s.


Format      Lint

@gregmagolan
Copy link
Member

Thanks @ahans!

@gregmagolan gregmagolan merged commit 262eca6 into aspect-build:main Oct 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants