Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add orion plugin to generate js_binary for main.{js,ts} #368

Merged
merged 3 commits into from
Oct 13, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Oct 12, 2024

Change the "library" package entry points to "lib.{js,ts}" to distinguish them from "apps" that have "main.{js,ts}".

Add an orion plugin to generate js_binary whenever a "src/main.{js,ts}".


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

Copy link

aspect-workflows bot commented Oct 12, 2024

Test

All tests were cache hits

25 tests (100.0%) were fully cached saving 11s.


Format      Lint

@jbedard jbedard marked this pull request as ready for review October 12, 2024 23:34
@jbedard jbedard enabled auto-merge (rebase) October 12, 2024 23:35
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@jbedard jbedard merged commit 96bc2b1 into aspect-build:main Oct 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants