Check for status failed

aspect-build · Apr 29, 2024 · 4748cb8 · 4748cb8
1 parent eda9d77
commit 4748cb8
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 9 deletions.
diff --git a/cypress/defs.bzl b/cypress/defs.bzl
@@ -78,8 +78,7 @@ def cypress_module_test(name, runner, cypress = "//:node_modules/cypress", **kwa
     cypress.run({
     headless: true,
     }).then(result => {
-    // Cypress only reports a status on failures
-    if (result.status) {
+    if (result.status === 'failed') {
         process.exit(1);
     }
     })

diff --git a/docs/defs.md b/docs/defs.md
diff --git a/docs/rules.md b/docs/rules.md
diff --git a/e2e/workspace/MODULE.bazel b/e2e/workspace/MODULE.bazel
@@ -3,9 +3,11 @@ local_path_override(
     module_name = "aspect_rules_cypress",
     path = "../..",
 )
+
 cypress = use_extension("@aspect_rules_cypress//cypress:extensions.bzl", "cypress")
 cypress.toolchain(cypress_version = "13.6.6")
 use_repo(cypress, "cypress_toolchains")
+
 register_toolchains("@cypress_toolchains//:all")
 
 bazel_dep(name = "aspect_rules_js", version = "1.41.2", dev_dependency = True)

diff --git a/e2e/workspace/module_test/runner.js b/e2e/workspace/module_test/runner.js
@@ -12,9 +12,7 @@ async function main() {
     return 1;
   }
 
-  // Cypress only reports a status on failures
-  if (result.status) {
-    console.error("Cypress tests failed with status", result.status);
+  if (result.status === "failed") {
     return 2;
   }