Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove select statements from generated repo #77

Closed
wants to merge 1 commit into from
Closed

fix: Remove select statements from generated repo #77

wants to merge 1 commit into from

Conversation

mrmeku
Copy link
Contributor

@mrmeku mrmeku commented May 1, 2024

Using a select statement breaks things when the
execution platform and host platform are
mismatched

Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: no
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: no

Test plan

  • Manual testing; please provide instructions so we can reproduce:
    Ran on local repository to verify

@mrmeku mrmeku requested a review from gregmagolan May 1, 2024 19:59
@mrmeku mrmeku mentioned this pull request May 1, 2024
Merged
@mrmeku Graphite App
Copy link
Contributor Author

mrmeku commented May 1, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mrmeku and the rest of your teammates on Graphite Graphite

@mrmeku mrmeku mentioned this pull request May 1, 2024
Merged
gregmagolan
gregmagolan requested changes May 14, 2024
View reviewed changes
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets discussion to determine if there any unexpected side-effects. Might be the right shape for RBE but will it break the target platform when building for docker containers?

@gregmagolan
Copy link
Member

@alexeagle Could use your brain on this one as well

@mrmeku mrmeku marked this pull request as draft June 26, 2024 16:28
@mrmeku mrmeku force-pushed the mrmeku-remove_select branch 2 times, most recently from da6b05f to 264cb85 Compare August 14, 2024 19:37
@mrmeku mrmeku changed the base branch from prefactor to main August 14, 2024 19:38
@mrmeku mrmeku marked this pull request as ready for review August 14, 2024 19:38
@mrmeku
fix: Remove select statements from generated repo
a7dba1c 
Using a select statement breaks things when the
execution platform and host platform are
mismatched
@mrmeku mrmeku closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan Awaiting requested review from gregmagolan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmeku @gregmagolan