feat: Create js_run_devserver target in macro #92
Conversation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
cypress/private/cypress_test.bzl
Outdated
| cypress_files = ctx.toolchains["@aspect_rules_cypress//cypress:toolchain_type"].cypressinfo.tool_files | ||
|
|
||
| files = ctx.files.data[:] + cypress_files + ctx.files.browsers | ||
|
|
||
| if ctx.attr.chdir: | ||
| cypress_bin = "/".join([".." for _ in ctx.attr.chdir.split("/")] + [cypress_bin]) | ||
| # TODO: Augment rules_js to expose EXECROOT before setting fixed_env. Then use that variable. |
There was a problem hiding this comment.
@gregmagolan What do you think about this TODO? Is that a sane change to rules_js? Is this a sane way to lookup the execroot in the first place?
|
|
||
| launcher = js_binary_lib.create_launcher( | ||
| ctx, | ||
| log_prefix_rule_set = "aspect_rules_cypess", | ||
| log_prefix_rule = "cypress_node_test", | ||
| fixed_args = ctx.attr.fixed_args, | ||
| fixed_env = { | ||
| "CYPRESS_RUN_BINARY": cypress_bin, | ||
| "HOME": "$$TEST_TMPDIR", |
There was a problem hiding this comment.
TEST_TMPDIR isn't defined in bazel run so I removed these. I'd like to keep them and use something like or if they aren't defined. Any suggestions @gregmagolan ?
There was a problem hiding this comment.
Why did we set HOME in the first place? Guessing cypress was trying to write to the home directory when it the sandbox and failing?
mrmeku
force-pushed
the
mrmeku-cypress.open
branch
2 times, most recently
from
973b560
to
98c52d1
Compare
For every `cypress_test` the macro now generates a supplementary target `[name].open` which runs cypress using js_run_devserver. This allows users to use ibazel to interactively update their tests.
mrmeku
force-pushed
the
mrmeku-cypress.open
branch
from
98c52d1
to
94beda2
Compare
| if ctx.attr.chdir: | ||
| cypress_bin = "/".join([".." for _ in ctx.attr.chdir.split("/")] + [cypress_bin]) | ||
| # TODO: Augment rules_js to expose JS__EXECROOT before setting fixed_env. Then use that variable. | ||
| execroot = "$$( realpath \"$${BASH_SOURCE[0]}\" | sed -E 's/^(.*\\/execroot\\/[^/]+).*/\\1/')" |
There was a problem hiding this comment.
Hmm. Dep on realpath not great and it will also escape the sandbox this way.
There was a problem hiding this comment.
We should probably augment rules_js to support what you want here instead of this line
Every
cypress_testthe macro now generatesa supplementary target
[name].openwhich runscypress using js_run_devserver. This allows users
to use ibazel to interactively update their tests.
Changes are visible to end-users: yes
Test plan
cypress_testmacro now creates another target with name[name].open. This target runscypress openusing js_run_devserver. It is meant to be run withibazelso that your tests can be updated interactively.