Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add esbuild(define) tests #144

Merged
merged 1 commit into from
Mar 27, 2023
Merged

test: add esbuild(define) tests #144

merged 1 commit into from
Mar 27, 2023

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Mar 27, 2023

Wrote this to debug something and seems worth adding...

@gregmagolan
Copy link
Member

gregmagolan commented Mar 27, 2023

Looks like a platform specific CI failure:

==================== Test output for //examples/define:assertions_test:
5,6c5,6
<   console.log("OUTPUT_DIR: ", "bazel-out/k8-fastbuild/bin/examples/define");
<   console.log("RULE_DIR: ", "bazel-out/k8-fastbuild/bin/examples/define");
---
>   console.log("OUTPUT_DIR: ", "bazel-out/darwin_arm[64](https://github.com/aspect-build/rules_esbuild/actions/runs/4536183799/jobs/7992566293?pr=144#step:6:65)-fastbuild/bin/examples/define");
>   console.log("RULE_DIR: ", "bazel-out/darwin_arm64-fastbuild/bin/examples/define");
FAIL: files "examples/define/sed_bundle_production.js" and "examples/define/bundle_production.expected" differ. 

@@//examples/define:bundle_production.expected is out of date. To update this file, run:

    bazel run //examples/define:assertions

@jbedard
Copy link
Member Author

jbedard commented Mar 27, 2023

Opps, had to adjust the regex to handle the additional paths.

@gregmagolan gregmagolan merged commit 50920ae into main Mar 27, 2023
@gregmagolan gregmagolan deleted the define-var branch March 27, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants