refactor: remove vendored jasmine versions, user must provider their …

…own jasmine from their node_modules (#44)

.npmrc

@@ -0,0 +1,4 @@
+# Disabling pnpm [hoisting](https://pnpm.io/npmrc#hoist) by setting `hoist=false` is recommended on
+# projects using rules_js so that pnpm outside of Bazel lays out a node_modules tree similar to what
+# rules_js lays out under Bazel (without a hidden node_modules/.pnpm/node_modules)
+hoist=false

BUILD.bazel

@@ -1,5 +1,8 @@
 load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 load("@bazel_gazelle//:def.bzl", "gazelle", "gazelle_binary")
+load("@npm//:defs.bzl", "npm_link_all_packages")
+
+npm_link_all_packages(name = "node_modules")
 
 gazelle_binary(
     name = "gazelle_bin",

WORKSPACE

@@ -21,13 +21,18 @@ nodejs_register_toolchains(
     node_version = DEFAULT_NODE_VERSION,
 )
 
-load("//jasmine:repositories.bzl", "jasmine_repositories")
+load("@aspect_rules_js//npm:npm_import.bzl", "npm_translate_lock")
 
-jasmine_repositories(name = "jasmine")
+npm_translate_lock(
+    name = "npm",
+    npmrc = "//:.npmrc",
+    pnpm_lock = "//:pnpm-lock.yaml",
+    verify_node_modules_ignored = "//:.bazelignore",
+)
 
-load("@jasmine//:npm_repositories.bzl", jasmine_npm_repositories = "npm_repositories")
+load("@npm//:repositories.bzl", "npm_repositories")
 
-jasmine_npm_repositories()
+npm_repositories()
 
 # For running our own unit tests
 load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")

e2e/jasmine_test/.bazelignore

@@ -0,0 +1 @@
+node_modules

e2e/jasmine_test/.npmrc

@@ -0,0 +1,4 @@
+# Disabling pnpm [hoisting](https://pnpm.io/npmrc#hoist) by setting `hoist=false` is recommended on
+# projects using rules_js so that pnpm outside of Bazel lays out a node_modules tree similar to what
+# rules_js lays out under Bazel (without a hidden node_modules/.pnpm/node_modules)
+hoist=false

e2e/jasmine_test/BUILD.bazel

@@ -1,12 +1,16 @@
 load("@aspect_rules_jasmine//jasmine:defs.bzl", "jasmine_test")
+load("@npm//:defs.bzl", "npm_link_all_packages")
+
+npm_link_all_packages(name = "node_modules")
 
 jasmine_test(
     name = "test",
+    args = ["*.spec.js"],
     data = [
         "lib.js",
         "lib.spec.js",
         "lib.test.js",
         "package.json",
     ],
-    args = ["*.spec.js"],
+    node_modules = "//:node_modules",
 )

e2e/jasmine_test/WORKSPACE

@@ -15,10 +15,15 @@ nodejs_register_toolchains(
     node_version = DEFAULT_NODE_VERSION,
 )
 
-load("@aspect_rules_jasmine//jasmine:repositories.bzl", "jasmine_repositories")
+load("@aspect_rules_js//npm:npm_import.bzl", "npm_translate_lock")
 
-jasmine_repositories(name = "jasmine")
+npm_translate_lock(
+    name = "npm",
+    npmrc = "//:.npmrc",
+    pnpm_lock = "//:pnpm-lock.yaml",
+    verify_node_modules_ignored = "//:.bazelignore",
+)
 
-load("@jasmine//:npm_repositories.bzl", jasmine_npm_repositories = "npm_repositories")
+load("@npm//:repositories.bzl", "npm_repositories")
 
-jasmine_npm_repositories()
+npm_repositories()

e2e/jasmine_test/package.json

@@ -1 +1,9 @@
-{"type": "module"}
+{
+  "private": true,
+  "type": "module",
+  "devDependencies": {
+    "jasmine": "4.6.0",
+    "jasmine-core": "4.6.0",
+    "jasmine-reporters": "2.5.2"
+  }
+}

e2e/jasmine_test/pnpm-workspace.yaml

@@ -0,0 +1,2 @@
+packages:
+  - "."

e2e/workspace/.bazelignore

@@ -0,0 +1 @@
+node_modules

e2e/workspace/.npmrc

@@ -0,0 +1,4 @@
+# Disabling pnpm [hoisting](https://pnpm.io/npmrc#hoist) by setting `hoist=false` is recommended on
+# projects using rules_js so that pnpm outside of Bazel lays out a node_modules tree similar to what
+# rules_js lays out under Bazel (without a hidden node_modules/.pnpm/node_modules)
+hoist=false

e2e/workspace/BUILD

@@ -1,9 +1,13 @@
 """Provides a simple way to test your rules as an external workspace."""
 
-load("@jasmine//:defs.bzl", "jasmine_test")
+load("@aspect_rules_jasmine//jasmine:defs.bzl", "jasmine_test")
+load("@npm//:defs.bzl", "npm_link_all_packages")
+
+npm_link_all_packages(name = "node_modules")
 
 jasmine_test(
     name = "test",
     args = ["*.spec.js"],
     data = ["test.spec.js"],
+    node_modules = "//:node_modules",
 )

e2e/workspace/WORKSPACE

@@ -27,10 +27,15 @@ nodejs_register_toolchains(
     node_version = DEFAULT_NODE_VERSION,
 )
 
-load("@aspect_rules_jasmine//jasmine:repositories.bzl", "jasmine_repositories")
+load("@aspect_rules_js//npm:npm_import.bzl", "npm_translate_lock")
 
-jasmine_repositories(name = "jasmine")
+npm_translate_lock(
+    name = "npm",
+    npmrc = "//:.npmrc",
+    pnpm_lock = "//:pnpm-lock.yaml",
+    verify_node_modules_ignored = "//:.bazelignore",
+)
 
-load("@jasmine//:npm_repositories.bzl", jasmine_npm_repositories = "npm_repositories")
+load("@npm//:repositories.bzl", "npm_repositories")
 
-jasmine_npm_repositories()
+npm_repositories()

e2e/workspace/package.json

@@ -0,0 +1,9 @@
+{
+  "private": true,
+  "type": "module",
+  "devDependencies": {
+    "jasmine": "4.6.0",
+    "jasmine-core": "4.6.0",
+    "jasmine-reporters": "2.5.2"
+  }
+}