Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump minimum rules_nodejs to 6.2.0 #159

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Jun 8, 2024

Ensures users pick up bazel-contrib/rules_nodejs#3760 fix which is a footgun that should be avoided.

@gregmagolan gregmagolan requested a review from jbedard June 8, 2024 21:15
@gregmagolan gregmagolan enabled auto-merge (squash) June 8, 2024 21:16
Copy link

aspect-workflows bot commented Jun 8, 2024

Test

15 test targets passed

Targets
//examples/commonjs:test [k8-fastbuild]                                 165ms
//examples/simple:test [k8-fastbuild]                                   168ms
//jasmine/tests/fixed_args:fixed_args_bash_launcher_test [k8-fastbuild] 61ms
//jasmine/tests/fixed_args:test [k8-fastbuild]                          263ms
//jasmine/tests:cjs [k8-fastbuild]                                      227ms
//jasmine/tests:config [k8-fastbuild]                                   175ms
//jasmine/tests:config_chdir_package_name [k8-fastbuild]                142ms
//jasmine/tests:esm [k8-fastbuild]                                      251ms
//jasmine/tests:exclusions [k8-fastbuild]                               178ms
//jasmine/tests:failing [k8-fastbuild]                                  223ms
//jasmine/tests:failing_shard [k8-fastbuild]                            352ms
//jasmine/tests:focused [k8-fastbuild]                                  165ms
//jasmine/tests:junit_reporter [k8-fastbuild]                           198ms
//jasmine/tests:shard [k8-fastbuild]                                    683ms
//jasmine/tests:stack [k8-fastbuild]                                    179ms

Total test execution time was 3s. 10 tests (40.0%) were fully cached saving 3s.


Buildifier      Format

@gregmagolan gregmagolan merged commit c468522 into main Jun 8, 2024
20 checks passed
@gregmagolan gregmagolan deleted the bump_rules_nodejs branch June 8, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants