perf: use rules_js Bazel 6 optimized fs patches if using Bazel 6 and experimental_allow_unresolved_symlinks is on #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rules_js js_test base attributes that jasmine_test uses requires setting
unresolved_symlinks_enabled
to True based on the@aspect_rules_js//js/private:experimental_allow_unresolved_symlinks
condition to enable the optimized Bazel 6 patches only when the user is using Bazel 6 AND unresolved symlinks are enabled. They are enabled by default but they can be disabled by the user so we need to check anyway.Type of change
For changes visible to end-users
For WORKSPACE users that are pinning
aspect_rules_js
, this bumps the minimum rules_js version required for rules_jasmine compatibility to 1.24.0. WORKSPACE that get the version of rules_js transitively fromrules_jasmine_dependencies
are not affected. bzlmod users are also not affected since bzlmod ensure the minimum version of rules_js that rules_jasmine requires is used.Test plan