Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use rules_js Bazel 6 optimized fs patches if using Bazel 6 and experimental_allow_unresolved_symlinks is on #55

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Apr 12, 2023

rules_js js_test base attributes that jasmine_test uses requires setting unresolved_symlinks_enabled to True based on the @aspect_rules_js//js/private:experimental_allow_unresolved_symlinks condition to enable the optimized Bazel 6 patches only when the user is using Bazel 6 AND unresolved symlinks are enabled. They are enabled by default but they can be disabled by the user so we need to check anyway.

Type of change

  • Performance (a code change that improves performance)

For changes visible to end-users

  • Breaking change (this change will force users to change their own code or config)

For WORKSPACE users that are pinning aspect_rules_js, this bumps the minimum rules_js version required for rules_jasmine compatibility to 1.24.0. WORKSPACE that get the version of rules_js transitively from rules_jasmine_dependencies are not affected. bzlmod users are also not affected since bzlmod ensure the minimum version of rules_js that rules_jasmine requires is used.

Test plan

  • Covered by existing test cases

…experimental_allow_unresolved_symlinks is on
@gregmagolan gregmagolan merged commit 4c9e861 into main Apr 12, 2023
@gregmagolan gregmagolan deleted the bazel_6_perf branch April 12, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants