Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump minimum rules_nodejs to 6.2.0 #1792

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Jun 8, 2024

Ensures users pick up bazel-contrib/rules_nodejs#3760 fix which is a footgun that should be avoided.

@gregmagolan gregmagolan requested a review from jbedard June 8, 2024 21:18
Copy link

aspect-workflows bot commented Jun 8, 2024

Test

83 test targets passed

Targets
//examples/coverage:coverage [k8-fastbuild]                                                                66ms
//examples/genrule:test_acorn [k8-fastbuild]                                                               40ms
//examples/genrule:test_require_acorn [k8-fastbuild]                                                       99ms
//examples/js_binary:aspect_bin_a_test [k8-fastbuild]                                                      177ms
//examples/js_binary:case7_test [k8-fastbuild]                                                             171ms
//examples/js_binary:npm_version_test [k8-fastbuild]                                                       1s
//examples/js_binary:test13-1 [k8-fastbuild]                                                               38ms
//examples/js_binary:test13-2 [k8-fastbuild]                                                               32ms
//examples/js_binary:test4-a [k8-fastbuild]                                                                59ms
//examples/js_binary:test4-b [k8-fastbuild]                                                                76ms
//examples/js_binary:test5 [k8-fastbuild]                                                                  79ms
//examples/js_binary:test6 [k8-fastbuild]                                                                  51ms
//examples/js_binary:test6_alt [k8-fastbuild]                                                              138ms
//examples/js_binary:test8 [k8-fastbuild]                                                                  41ms
//examples/js_binary:test_exitcode [k8-fastbuild]                                                          135ms
//examples/js_binary:test_js_binary_under_custom_rule [k8-fastbuild]                                       58ms
//examples/js_binary:test_js_binary_under_custom_rule_local [k8-fastbuild]                                 85ms
//examples/js_binary:test_js_binary_under_genrule [k8-fastbuild]                                           25ms
//examples/js_binary:test_js_binary_under_js_run_binary [k8-fastbuild]                                     112ms
//examples/js_binary:test_js_binary_under_js_run_binary_local [k8-fastbuild]                               99ms
//examples/js_binary:test_js_binary_under_js_run_binary_no_copy_data_to_bin [k8-fastbuild]                 161ms
//examples/js_binary:test_stderr [k8-fastbuild]                                                            61ms
//examples/js_binary:test_stdout [k8-fastbuild]                                                            85ms
//examples/js_binary:test_test [k8-fastbuild]                                                              183ms
//examples/js_library/two:two_test [k8-fastbuild]                                                          87ms
//examples/macro:test [k8-fastbuild]                                                                       667ms
//examples/npm_deps:rollup_version_test [k8-fastbuild]                                                     186ms
//examples/npm_deps:test1 [k8-fastbuild]                                                                   109ms
//examples/npm_deps:test3 [k8-fastbuild]                                                                   153ms
//examples/npm_deps:test4 [k8-fastbuild]                                                                   217ms
//examples/npm_deps:test5 [k8-fastbuild]                                                                   62ms
//examples/npm_deps:test5_alt [k8-fastbuild]                                                               151ms
//examples/npm_deps:test6 [k8-fastbuild]                                                                   162ms
//examples/npm_deps:test7 [k8-fastbuild]                                                                   346ms
//examples/npm_deps:test8 [k8-fastbuild]                                                                   239ms
//examples/npm_deps:test9 [k8-fastbuild]                                                                   116ms
//examples/npm_deps:test_peer [k8-fastbuild]                                                               157ms
//examples/npm_deps:test_uvu_version [k8-fastbuild]                                                        233ms
//examples/webpack_cli:test [k8-fastbuild]                                                                 1s
//js/private/coverage:coverage_checked_test [k8-fastbuild]                                                 53ms
//js/private/node-patches:checked_in_compile_test [k8-fastbuild]                                           58ms
//js/private/test/coverage:fail [k8-fastbuild]                                                             165ms
//js/private/test/coverage:pass [k8-fastbuild]                                                             160ms
//js/private/test/create_launcher:test [k8-fastbuild]                                                      133ms
//js/private/test/data:extract-js_run_binary-srcs [k8-fastbuild]                                           177ms
//js/private/test/data:extract-write-generated [k8-fastbuild]                                              121ms
//js/private/test/data:extract-write-js_library-data [k8-fastbuild]                                        96ms
//js/private/test/data:extract-write-js_library-srcs [k8-fastbuild]                                        88ms
//js/private/test/data:from-data [k8-fastbuild]                                                            90ms
//js/private/test/data:from-filegroup-srcs [k8-fastbuild]                                                  83ms
//js/private/test/data:from-genrule [k8-fastbuild]                                                         83ms
//js/private/test/data:from-genrule-data [k8-fastbuild]                                                    88ms
//js/private/test/data:from-js_library-data [k8-fastbuild]                                                 75ms
//js/private/test/data:from-js_library-srcs [k8-fastbuild]                                                 85ms
//js/private/test/data:from-js_run_binary-genrule [k8-fastbuild]                                           221ms
//js/private/test/data:from-js_run_binary-genrule-copied [k8-fastbuild]                                    205ms
//js/private/test/data:from-js_run_binary-js_library-data [k8-fastbuild]                                   213ms
//js/private/test/data:from-js_run_binary-js_library-srcs [k8-fastbuild]                                   134ms
//js/private/test/data:from-js_run_binary-srcs [k8-fastbuild]                                              210ms
//js/private/test/data:from-parent-genrule [k8-fastbuild]                                                  91ms
//js/private/test/data:from-parent-js_library-data [k8-fastbuild]                                          231ms
//js/private/test/image:checksum_test_test [k8-fastbuild]                                                  65ms
//js/private/test/js_binary_sh:regexy-args [k8-fastbuild]                                                  58ms
//js/private/test/js_run_devserver:js_run_devserver_test [k8-fastbuild]                                    185ms
//js/private/test/js_run_devserver:node_modules_symlink_to_execroot_test [k8-fastbuild]                    256ms
//js/private/test/no_copy_to_bin:no_copy_to_bin_test [k8-fastbuild]                                        184ms
//js/private/test/node-patches:escape_test [k8-fastbuild]                                                  210ms
//js/private/test/node-patches:lstat_test [k8-fastbuild]                                                   186ms
//js/private/test/node-patches:opendir_test [k8-fastbuild]                                                 238ms
//js/private/test/node-patches:readdir_test [k8-fastbuild]                                                 179ms
//js/private/test/node-patches:readlink_test [k8-fastbuild]                                                279ms
//js/private/test/node-patches:realpath_test [k8-fastbuild]                                                229ms
//js/private/test/node-patches:spawn_test_node16 [k8-fastbuild]                                            1s
//js/private/test/node-patches:spawn_test_node18 [k8-fastbuild]                                            601ms
//js/private/test/node-patches:spawn_test_node20 [k8-fastbuild]                                            985ms
//js/private/test:main_default_toolchain [k8-fastbuild]                                                    132ms
//js/private/test:main_toolchain_16 [k8-fastbuild]                                                         217ms
//js/private/test:main_toolchain_18 [k8-fastbuild]                                                         148ms
//js/private/test:write_launcher_bzlmod_test [k8-fastbuild]                                                34ms
//js/private/worker:worker_checked_test [k8-fastbuild]                                                     151ms
//js/private:js_image_layer_checked_test [k8-fastbuild]                                                    47ms
//npm/private/test:__rollup-test [k8-fastbuild]                                                            281ms
//npm/private/test:node_modules_test [k8-fastbuild]                                                        20ms

Total test execution time was 16s. 110 tests (57.0%) were fully cached saving 26s.


Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 486ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 557ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 7s.


Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 1s.


Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 923ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 251ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 566ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

28 tests (100.0%) were fully cached saving 9s.


Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 3s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.


Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 453ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 605ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 187ms.


Buildifier      Format

@gregmagolan gregmagolan merged commit c753959 into main Jun 8, 2024
107 checks passed
@gregmagolan gregmagolan deleted the bump_rules_nodejs branch June 8, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants