Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(format): add SCSS and Less as CSS variants #248

Merged
merged 2 commits into from
May 21, 2024
Merged

feat(format): add SCSS and Less as CSS variants #248

merged 2 commits into from
May 21, 2024

Conversation

alexeagle
Copy link
Member

@alexeagle alexeagle commented May 21, 2024

  • break out these three as well as HTML rather than lumping with JavaScript.
  • add '.vue' as JavaScript dialect

Fixes #242
Fixes #243


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): yes
  • Suggested release notes appear below: yes

CSS is now a separate language from JavaScript. You must add an attribute to format_multirun like css = ":prettier" to continue formatting CSS files. Sass and Less are now included.

HTML is also now a separate language from JavaScript. Add html = ":prettier" to format_multirun to continue formatting HTML files.

JavaScript now includes ".vue" files, using Prettier.

Test plan

  • New test cases added

Also break out these three as well as HTML rather than lumping with JavaScript

Fixes #243
@alexeagle alexeagle requested a review from jbedard May 21, 2024 17:47
@alexeagle alexeagle merged commit a2a525a into main May 21, 2024
8 checks passed
@alexeagle alexeagle deleted the fmt branch May 21, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Add formatting support for SCSS and Less [FR]: Add formatting support for .vue files
2 participants