Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint): print relative paths in stylish output #337

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Conversation

alexeagle
Copy link
Member

Thanks @gregmagolan for walking me through the technique required.


Changes are visible to end-users: no

Test plan

  • Manual testing; please provide instructions so we can reproduce:
% ./lint.sh src:ts      
From bazel-out/darwin_arm64-fastbuild/bin/src/ts.AspectRulesLintESLint.out:

src/file.ts
  2:7  error  Type string trivially inferred from a string literal, remove type annotation  @typescript-eslint/no-inferrable-types
  7:1  error  Unnecessary try/catch wrapper                                                 no-useless-catch

✖ 2 problems (2 errors, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@alexeagle alexeagle merged commit 0e9dc31 into main Jul 18, 2024
8 checks passed
@alexeagle alexeagle deleted the stylish_rel branch July 18, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants