Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(format): Allow git-attributes to be set to true #384

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

mrmeku
Copy link
Contributor

@mrmeku mrmeku commented Sep 10, 2024

Prior to this change, if one of the git attributes used to disable format checks was set to a value
of true, it was still formatted since the only
valid syntax was setting the attribute without
any value.

After this change the attributes can be used without a value or with the value of true

Fixes #383


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

Test plan

  • New test cases added

Git attributes for disabling format checks now support both unset values and true. This allows for more flexible configuration when excluding files from formatting.

Prior to this change, if one of the git attributes
used to disable format checks was set to a value
of `true`, it was still formatted since the only
valid syntax was setting the attribute without
any value.

After this change the attributes can be used without
a value or with the value of `true`
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

format/private/format.sh Show resolved Hide resolved
@mrmeku mrmeku merged commit 5b004ff into aspect-build:main Sep 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: gitignored files still being formatted
2 participants