fix(format): Allow git-attributes to be set to true #384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, if one of the git attributes used to disable format checks was set to a value
of
true
, it was still formatted since the onlyvalid syntax was setting the attribute without
any value.
After this change the attributes can be used without a value or with the value of
true
Fixes #383
Changes are visible to end-users: yes
Test plan
Git attributes for disabling format checks now support both unset values and
true
. This allows for more flexible configuration when excluding files from formatting.