test: use write_source_files where possible

aspect-build · Mar 2, 2023 · bb8898c · bb8898c
1 parent d893b1e
commit bb8898c
Show file tree

Hide file tree

Showing 10 changed files with 38 additions and 30 deletions.
diff --git a/examples/out_dir/BUILD.bazel b/examples/out_dir/BUILD.bazel
@@ -1,5 +1,5 @@
 load("@aspect_rules_swc//swc:defs.bzl", "swc")
-load("@aspect_bazel_lib//lib:testing.bzl", "assert_outputs")
+load("@aspect_bazel_lib//lib:write_source_files.bzl", "write_source_files")
 
 swc(
     name = "compile",
@@ -11,17 +11,13 @@ swc(
     source_maps = True,
 )
 
-# Since the srcs were in a filegroup, the swc macro cannot pre-declare the outputs.
-# So there is no label ":a.js" that we can reference from the build file.
-# However, a.js is still produced as one of the default outputs of the compile rule.
-# We can verify this in an action that depends on the ":compile" rule and reads the files.
-assert_outputs(
-    name = "check_outputs",
-    actual = "compile",
-    expected = [
-        "examples/out_dir/out/a.js",
-        "examples/out_dir/out/a.js.map",
-        "examples/out_dir/out/b.js",
-        "examples/out_dir/out/b.js.map",
-    ],
-)
+# Assert that the output of "compile" rule matches the expected file.
+write_source_files(
+    name = "test",
+    files = {
+        "expected/a.js": ":out/a.js",
+        "expected/a.js.map": ":out/a.js.map",
+        "expected/b.js": ":out/b.js",
+        "expected/b.js.map": ":out/b.js.map",
+    },
+)
diff --git a/examples/out_dir/expected/a.js b/examples/out_dir/expected/a.js
diff --git a/examples/out_dir/expected/a.js.map b/examples/out_dir/expected/a.js.map
diff --git a/examples/out_dir/expected/b.js b/examples/out_dir/expected/b.js
diff --git a/examples/out_dir/expected/b.js.map b/examples/out_dir/expected/b.js.map
diff --git a/examples/root_dir/BUILD.bazel b/examples/root_dir/BUILD.bazel
@@ -1,5 +1,5 @@
 load("@aspect_rules_swc//swc:defs.bzl", "swc")
-load("@aspect_bazel_lib//lib:testing.bzl", "assert_outputs")
+load("@aspect_bazel_lib//lib:write_source_files.bzl", "write_source_files")
 
 swc(
     name = "compile",
@@ -12,17 +12,13 @@ swc(
     source_maps = True,
 )
 
-# Since the srcs were in a filegroup, the swc macro cannot pre-declare the outputs.
-# So there is no label ":a.js" that we can reference from the build file.
-# However, a.js is still produced as one of the default outputs of the compile rule.
-# We can verify this in an action that depends on the ":compile" rule and reads the files.
-assert_outputs(
-    name = "check_outputs",
-    actual = "compile",
-    expected = [
-        "examples/root_dir/out/a.js",
-        "examples/root_dir/out/a.js.map",
-        "examples/root_dir/out/b.js",
-        "examples/root_dir/out/b.js.map",
-    ],
-)
+# Assert that the output of "compile" rule matches the expected file.
+write_source_files(
+    name = "test",
+    files = {
+        "expected/a.js": ":out/a.js",
+        "expected/a.js.map": ":out/a.js.map",
+        "expected/b.js": ":out/b.js",
+        "expected/b.js.map": ":out/b.js.map",
+    },
+)
diff --git a/examples/root_dir/expected/a.js b/examples/root_dir/expected/a.js
diff --git a/examples/root_dir/expected/a.js.map b/examples/root_dir/expected/a.js.map
diff --git a/examples/root_dir/expected/b.js b/examples/root_dir/expected/b.js
diff --git a/examples/root_dir/expected/b.js.map b/examples/root_dir/expected/b.js.map