chore: ensure we don't try to compile any C++ code #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fmeum this fails for the wrong reason: rules_go doesn't ship with a binary of the Go stdlib. Can you suggest a different way to prevent transitives from accidentally compiling |
|
I sent #17 |
We don't have any C++ code in this repo, and want to make sure that our examples don't transitively depend on building protoc from source.
Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have any C++ code in this repo, and want to make sure that our examples don't transitively depend on building protoc from source.
#13 should have been red due to the issue I fixed in protocolbuffers/protobuf#17078
This change ensures that PR and any others that regress will be caught by CI.
It should be the case that users with a broken or non-hermetic CC toolchain are still able to work with Protocol Buffers.