Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with rules_proto 7 #30

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Fix compatibility with rules_proto 7 #30

merged 2 commits into from
Nov 14, 2024

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Nov 14, 2024

Changes are visible to end-users: no

Test plan

  • Manual testing; please provide instructions so we can reproduce: Bump rules_proto version to 7.0.2 and run tests.

@fmeum fmeum marked this pull request as ready for review November 14, 2024 10:46
alexeagle
alexeagle approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@alexeagle alexeagle merged commit 382ae8d into aspect-build:main Nov 14, 2024
8 checks passed
@fmeum fmeum deleted the rules_proto-7 branch November 14, 2024 18:02
@fmeum
Copy link
Contributor Author

fmeum commented Nov 14, 2024

@alexeagle Could you cut a new release with this change? That would help make rules_go compatible with AEGs.

@alexeagle
Copy link
Member 

To github.com:aspect-build/toolchains_protoc.git
 * [new tag]         v0.3.4 -> v0.3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmeum @alexeagle