ignore based on package dirent name prior to dot- adjustment
#116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
aspiers
force-pushed
the
fix-dot-ignore
branch
3 times, most recently
from
2dbf039
to
c3ae95f
Compare
If `--dotfiles` was enabled, files in the package such as `dot-gitignore` would be translated to `.gitignore` and then ignored by the default ignore list. However any file named `dot-*` in a package is obviously intended to be stowed as a dot file, so should not be ignored. To fix this, ignore based on the name in the package, not the potentially translated name used for stowing.
aspiers
force-pushed
the
fix-dot-ignore
branch
from
c3ae95f
to
37025f5
Compare
|
Now released in 2.4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
--dotfileswas enabled, files in the package such asdot-gitignorewould be translated to.gitignoreand then ignored by the default ignore list. However any file nameddot-*in a package is obviously intended to be stowed as a dot file, so should not be ignored.To fix this, ignore based on the name in the package, not the potentially translated name used for stowing.
This was first reported in #75 (comment).