Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create targeting pack for ASP.NET Core #6501

Closed
dsplaisted opened this issue Jan 8, 2019 · 1 comment
Closed

Create targeting pack for ASP.NET Core #6501

dsplaisted opened this issue Jan 8, 2019 · 1 comment
Assignees
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework feature-installers Includes: Installers

Comments

@dsplaisted
Copy link
Member

For .NET Core 3.0, we expect to separate targeting packs, which contain the assets needed at build time when targeting .NET Core 3.0 (for example, reference assemblies and intellisense documentation) from "runtime packs", which will include the platform-specific runtime components for .NET Core 3. See dotnet/cli#10006, and dotnet/designs#50

We will have targeting pack for each shared framework (.NET Core, ASP.NET Core, and WindowsDesktop), as well as for .NET Standard. This issue tracks the work required for the ASP.NET Core shared framework.

The work required includes:

  • A new NuGet package including the targeting pack assets. This should include the reference assemblies, intellisense documentation, and platform manifest file. The current straw man proposal for the package ID is Microsoft.NETCore.App.Ref
  • Installers for each supported installer format (msi, deb, pkg, and rpm), which lay out the targeting pack files under <DOTNET_ROOT>/packs/<PackageId>/version. These installers will be bundled or depended on by the corresponding .NET Core SDK installers.

Some of the details (such as package layout, names, etc) are still under design and may change slightly.

@natemcmaster natemcmaster added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework feature-installers Includes: Installers labels Jan 9, 2019
@Eilon Eilon removed the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 9, 2019
@natemcmaster natemcmaster self-assigned this Jan 22, 2019
@natemcmaster natemcmaster added this to the 3.0.0-preview3 milestone Jan 22, 2019
@natemcmaster
Copy link
Contributor

natemcmaster commented Jan 22, 2019

Until we have verified the details of the new design, we are planning to implement this side-by-side with our existing packages. Here is our current plan:

  • Create a new NuGet package Microsoft.AspNetCore.App.Ref which contains reference assemblies, docxml, and the platform manifest file
  • Create zip, tar, MSI, Debian, and RPM installers which place the contents of targeting pack into $DOTNET_ROOT/packs/Microsoft.AspNetCore.App.Ref/$version
  • Create new NuGet packages named Microsoft.AspNetCore.App.Runtime.$rid.
    - [x] Create zip, tar, MSI, Debian, and RPM installers which place the contents of runtime pack into $DOTNET_ROOT/packs/Microsoft.AspNetCore.App.Runtime.$rid/$version not necessary.

Details TBD:

  • Layout of the contents inside the NuGet packages.
  • The packageType to be used.
  • How do we specify package conflict overrides?
  • How do we specify platform manifests for updated runtimes? Current design only calls for these to be in the targeting pack.
  • Is this going to be ready to release in Preview 3?

cc @nguerrera @pakrym

natemcmaster added a commit that referenced this issue Feb 20, 2019
Part of #6501 

This adds a new Windows installer for the targeting pack. It places *.dll and *.xml (docs) in `[DOTNETHOME]\packs\Microsoft.AspNetCore.App.Ref\$(version)\ref\netcoreapp3.0`.

Outputs:
* aspnetcore-targeting-pack-$(version).zip
* aspnetcore-targeting-pack-$(version)-win-x64.exe (defaults to C:\Program Files\dotnet)
* aspnetcore-targeting-pack-$(version)-win-x86.exe (defaults to C:\Program Files (x86)\dotnet)

These all include the same files. These are meant to be bundled in the .NET Core SDK installer, but can be launched directly too.
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
@JunTaoLuo JunTaoLuo added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework feature-installers Includes: Installers
Projects
None yet
Development

No branches or pull requests

4 participants