Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build MSI installers for targeting pack #7726

Merged
merged 2 commits into from
Feb 20, 2019

Conversation

natemcmaster
Copy link
Contributor

@natemcmaster natemcmaster commented Feb 19, 2019

Part of #6501

This adds a new Windows installer for the targeting pack. It places *.dll and *.xml (docs) in "DOTNETHOME\packs\Microsoft.AspNetCore.App.Ref\$(version)\ref\netcoreapp3.0".

Outputs:

  • aspnetcore-targeting-pack-$(version).zip
  • aspnetcore-targeting-pack-$(version)-win-x64.exe (defaults to C:\Program Files\dotnet)
  • aspnetcore-targeting-pack-$(version)-win-x86.exe (defaults to C:\Program Files (x86)\dotnet)

These all include the same files.

These are meant to be bundled in the .NET Core SDK installer, but can be launched directly too.

image

cc @dsplaisted @nguerrera @DamianEdwards @davidfowl

@dsplaisted
Copy link
Member

in "DOTNETHOME\packs\Microsoft.AspNetCore.App.Ref$(version)\ref\netcoreapp3.0".

Is there a backslash missing after .Ref?

@natemcmaster
Copy link
Contributor Author

The slash is there. Forgot to escape my markdown comments

@natemcmaster
Copy link
Contributor Author

@dsplaisted @nguerrera assuming there is work on the core-sdk side to consume this. Is that something I'm expected to do, or are you handling it?

@nguerrera
Copy link
Contributor

We will handle the bundling. Looks like @johnbeisner has started on this for the base TP here: dotnet/installer#588 (review)

@natemcmaster natemcmaster merged commit a9c358b into dotnet:master Feb 20, 2019
@natemcmaster natemcmaster deleted the targeting-pack-msi branch February 20, 2019 00:28
@dsplaisted
Copy link
Member

@natemcmaster If you can let us know when there's a build of the MSIs on blob storage (ideally with the links to them), that will help us pick them up. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants