Add OptimizationPreference=Speed NativeAOT runs #1840
Conversation
This is now a documented option: https://learn.microsoft.com/en-us/dotnet/core/deploying/native-aot/optimizing I've put it on the same schedule as PGO runs since it's a similar thing but I don't know the motivation behind it. Should I tweak the modulus remainder to a different number than 1?
| @@ -40,6 +40,11 @@ parameters: | |||
| arguments: --scenario basicminimalapipublishaot $(goldilocksJobs) --property scenario=Stage1AotServerGC --property publish=nativeaot --application.packageReferences \"Microsoft.Dotnet.ILCompiler=$(MicrosoftNETCoreAppPackageVersion)\" --application.buildArguments \"/p:ServerGarbageCollection=true\" | |||
| condition: 'true' | |||
|
|
|||
| - displayName: Goldilocks Stage 1 (NativeAOT - Optimize for Speed) | |||
| # workaround https://github.com/dotnet/runtime/issues/81382 by explicitly referencing a Microsoft.Dotnet.ILCompiler version | |||
There was a problem hiding this comment.
@agocke @sbomer @vitek-karas - do we have a story in place for this issue and dotnet/runtime#84372 yet?
One thing that is annoying about this workaround is that when you copy the crank command out of the dashboard, it still has Microsoft.Dotnet.ILCompiler=$(MicrosoftNETCoreAppPackageVersion) in it, and when you simply run the command you get:
MicrosoftNETCoreAppPackageVersion: The term 'MicrosoftNETCoreAppPackageVersion' is not recognized as a name of a cmdlet, function, script file, or executable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
This pipeline is executed 2 times per day, but we don't need to run some of these jobs that often in order to limit how long each run takes. This property will send the command to crank only if the condition is true, in this case by specifying how many half-days it should run, every 6th one in this case. And then some of them run on the first 6th, the second one. This way the native-aot job will usually take the same amount of time even though not the same jobs run on each iteration. |
I think that would make sense. If we put the "OptimizationPreference=Speed" on a different day (but still every 6 half days). |
note that in the current code in main, there are 4 of these conditions. 3 of them are |
|
@eerhardt sure, you don't have to for the ones that you really want to track as much as possible. But since we don't do changes more often than twice a day it doesn't really make sense to not do it. |
|
Yep, I don't have permissions to merge this. Thanks! |
This is now a documented option: https://learn.microsoft.com/en-us/dotnet/core/deploying/native-aot/optimizing
I've put it on the same schedule as PGO runs since it's a similar thing but I don't know the motivation behind it. Should I tweak the modulus remainder to a different number than 1?
Cc @sebastienros @eerhardt @DamianEdwards @JamesNK