[Design] Refactor DataProtection #136
Conversation
| /// A simplified default implementation of <see cref="IActivator"/> that understands | ||
| /// how to call ctors which take <see cref="ILoggerFactory"/>. | ||
| /// </summary> | ||
| private sealed class SimpleActivator : IActivator |
There was a problem hiding this comment.
This needs to be removed. Needs some discussion on how to approach this scenario.
ajaybhargavb
force-pushed
the
refactor-dp
branch
2 times, most recently
from
c83c35c to
a87ca50
Compare
|
|
||
| namespace Microsoft.AspNetCore.DataProtection | ||
| { | ||
| public abstract class DataProtectionProvider : IDataProtectionProvider |
There was a problem hiding this comment.
Won't this type conflict with the one used by the extensions package?
There was a problem hiding this comment.
I guess one of these will probably have to be renamed.
There was a problem hiding this comment.
If you plan to include this PR in RC2, maybe it would be better to address that now?
There was a problem hiding this comment.
Yes. But this PR is still in design. I am planning to do all the documentation/test/renames in a later update.
ajaybhargavb
force-pushed
the
refactor-dp
branch
from
a87ca50 to
0a1ade8
Compare
|
🆙 📅 |
| @@ -37,55 +37,8 @@ public static T CreateInstance<T>(this IActivator activator, string implementati | |||
| public static IActivator GetActivator(this IServiceProvider serviceProvider) | |||
There was a problem hiding this comment.
This is strange as an extension method. Services are one of those things that you should know if it's null or not.
|
Closing this since the latest work is on a different branch |
Issue - #134
@rynowak @loudej @lodejard
Things that still need cleanup: