This repository has been archived by the owner on Oct 17, 2018. It is now read-only.
Add an abstraction for pre-initializing DataProtection #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… might need to run early in an application lifecycle
ajaybhargavb
approved these changes
Jun 1, 2017
| [Fact] | ||
| public void LoadsKeyRingDuringInitialization() | ||
| { | ||
| var mock = new Mock<IKeyRingProvider>(); |
There was a problem hiding this comment.
//Arrange //Act //Assert
|
We decided to flip the Hosting <-> DataProtection dependency order (again) so that we don't have to do this. See #240 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR aspnet/Hosting#1096
Should reduce delay on first request caused by initializing data protection (#193) and avoid thread pool starvation when server starts under high load ( #233 ).